[libvirt] [PATCH v2 3/5] test: Introduce testing of virStorageUtilGlusterExtractPoolSources

Andrea Bolognani abologna at redhat.com
Tue Apr 4 12:06:38 UTC 2017


On Tue, 2017-04-04 at 13:50 +0200, Peter Krempa wrote:
> > > +#undef DO_TEST_GLUSTER_LOOKUP_NATIVE
> > > +#undef DO_TEST_GLUSTER_LOOKUP_NETFS
> > > +#undef DO_TEST_GLUSTER_LOOKUP_FULL
> > 
> > The #undefs are a bit unnecessary in this context, I'd leave
> > them out.
> 
> It's true that it would be hard to use these somewhere else (since they
> are in a .c file) but ad-hoc macros should be undefined. Otherwise they
> are not ad-hoc and should bear the VIR_ prefix.

Feel free to leave the hunk in then :)

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list