[libvirt] [PATCH 01/15] nwfilter: Use consistent naming for variables

Pavel Hrdina phrdina at redhat.com
Tue Apr 25 13:13:08 UTC 2017


On Mon, Apr 24, 2017 at 03:18:30PM -0400, John Ferlan wrote:
> When processing a virNWFilterPtr use 'nwfilter' as a variable name.
> 
> When processing a virNWFilterObjPtr use 'obj' as a variable name.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/conf/virnwfilterobj.c      | 92 +++++++++++++++++++++---------------------
>  src/conf/virnwfilterobj.h      |  7 ++--
>  src/nwfilter/nwfilter_driver.c | 78 +++++++++++++++++------------------
>  3 files changed, 89 insertions(+), 88 deletions(-)

I'll just loudly object that this is not necessary but on the other hand
it makes following the code through different functions easier.

Weak ACK, if there are on objections from others.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170425/a332bd9b/attachment-0001.sig>


More information about the libvir-list mailing list