[libvirt] [PATCH v2 03/11] secret: Use consistent naming for variables

Pavel Hrdina phrdina at redhat.com
Wed Apr 26 08:29:54 UTC 2017


On Tue, Apr 25, 2017 at 05:15:27PM -0400, John Ferlan wrote:
> When processing a virSecretPtr use 'secret' as a variable name.
> 
> When processing a virSecretObjPtr use 'obj' as a variable name.
> 
> When processing a virSecretDefPtr use 'def' as a variable name,
> unless a distinction needs to be made with a 'newdef' such as
> virSecretObjListAddLocked (which also used the VIR_STEAL_PTR macro
> for the configFile and base64File).
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/conf/virsecretobj.c    | 271 ++++++++++++++++++++++-----------------------
>  src/conf/virsecretobj.h    |  26 ++---
>  src/secret/secret_driver.c | 139 ++++++++++++-----------
>  3 files changed, 223 insertions(+), 213 deletions(-)

This patch has a some unrelated newline changes, that's for a separate patch.

ACK if you remove them.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170426/2df81513/attachment-0001.sig>


More information about the libvir-list mailing list