[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] nodedev: mdev: Report an error when virFileResolveLink fails




On 07/26/2017 02:44 AM, Erik Skultety wrote:
> It might happen that virFileResolveLinkHelper fails on the lstat system
> call. virFileResolveLink expects the caller to report an error when it
> fails, however this wasn't the case for udevProcessMediatedDevice.
> 
> Signed-off-by: Erik Skultety <eskultet redhat com>
> ---
>  src/node_device/node_device_udev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Could have gone with "resolve mdev path" or "resolve mediated device
path"...  Just makes it clear what failed.


Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]