[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 24/24] tests: qemumonitorjson: Test extraction of iSCSI device node names



On Wed, Aug 02, 2017 at 13:50:49 +0200, Bjoern Walk wrote:
> So, this test fails on S390 because the actual test in
> testBlockNodeNameDetect is dependent on the ordering of the entries in
> the hash table, which is different on big endian machines.
> 
> There are two other tests which have multiple results in the backing
> chain, 'same-backing' and 'relative', but their keys are reasonable
> similar that we got lucky and the hashes are ordered the same.
> 
> I don't suspect that code that uses the tested function,
> qemuBlockNodeNameGetBackingChain, is dependent on the ordering of keys
> so this is actually only a problem in the test suite.

Yes, the hash function is non-deterministic. I'm working on mocking it
so that it uses a simpler algorithm which will be endian independent.

> 
> Sorry for the late notice for this.

Well, since the issue is not in this series, but the other tests needing
specific ordering were lucky enough to be ordered the same way, it was
rather hard to catch.

> 
> Bjoern



> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]