[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent



On Thu, Aug 03, 2017 at 07:24:35 +0200, Bjoern Walk wrote:
> Peter Krempa <pkrempa redhat com> [2017-08-02, 05:39PM +0200]:
> > It turns out that our implementation of the hashing function is
> > endian-dependent and thus if used on various architectures the testsuite
> > may have different results. Work this around by mocking virHashCodeGen
> > to something which does not use bit operations instead of just setting a
> > deterministic seed.
> 
> This does fix the issue on S390. Anyways, I'd also like to see the tests
> fixed that rely on the ordering of the hash table. And code that uses

The tests are fixed. They are ordered correctly to the newly mocked
function. I don't quite get what more you'd like to see fixed.

> the hash table should be tested that it does NOT rely on the ordering.

Well, that's a property of the hash table that the code should not
depend on ordering. In fact the only part which is slightly dependant on
ordering is the test suite. The fix to mock the ordering function
properly is tested.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]