[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] Fix smartcard formatting regression




On 08/03/2017 08:55 AM, Ján Tomko wrote:
> *** BLURB HERE ***
> 
> Ján Tomko (2):
>   tests: add smartcard test cases to qemuxml2xmltest
>   conf: fix formatting of smartcard devices
> 
>  src/conf/domain_conf.c                             | 43 ++++++++++++++--------
>  .../qemuxml2xmlout-smartcard-controller.xml        | 31 ++++++++++++++++
>  .../qemuxml2xmlout-smartcard-host-certificates.xml | 34 +++++++++++++++++
>  .../qemuxml2xmlout-smartcard-host.xml              | 31 ++++++++++++++++
>  ...muxml2xmlout-smartcard-passthrough-spicevmc.xml | 31 ++++++++++++++++
>  .../qemuxml2xmlout-smartcard-passthrough-tcp.xml   | 33 +++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  6 +++
>  7 files changed, 194 insertions(+), 15 deletions(-)
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-smartcard-controller.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-smartcard-host-certificates.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-smartcard-host.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-smartcard-passthrough-spicevmc.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-smartcard-passthrough-tcp.xml
> 

I'm fine with this solution - instead of what I posted:

https://www.redhat.com/archives/libvir-list/2017-August/msg00101.html

The only differences between the two are:

 1. Where the virBufferAddLit(buf, ">\n"); is placed for all callers

 2. How the smartcard passthrough is processed

I posted mainly as a means to have "something" available - I can drop my
series...

Reviewed-by: John Ferlan <jferlan redhat com>

Although I assume you're going to merge them together so as to not break
git bisect, right?

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]