[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 2/5] testCompareMemLock: Use correct free function for domain def



This is a nice example of volkswagened code. It passes tests but
doesn't work as expected really. virDomainDef is not an instance
of virObject thus virObjectUnref() is not the correct function to
be called.

Signed-off-by: Michal Privoznik <mprivozn redhat com>
---
 tests/qemumemlocktest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemumemlocktest.c b/tests/qemumemlocktest.c
index 66ebabb65..62bd25450 100644
--- a/tests/qemumemlocktest.c
+++ b/tests/qemumemlocktest.c
@@ -50,7 +50,7 @@ testCompareMemLock(const void *data)
     ret = virTestCompareToULL(info->memlock, qemuDomainGetMemLockLimitBytes(def));
 
  cleanup:
-    virObjectUnref(def);
+    virDomainDefFree(def);
     VIR_FREE(xml);
 
     return ret;
-- 
2.13.0


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]