[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] Two Coverity Fixes (thanks John!)




On 08/13/2017 11:44 AM, Laine Stump wrote:
> John found these two problems with Coverity after I pushed my series
> fixing MAC address saving/setting on Mellanox dual port NICs.
> 
> Laine Stump (2):
>   util: fix Coverity complaint (and actual bug) in
>     virHostdevReadNetConfig()
>   util: fix Coverity complaint in virNetDevSetNetConfig()
> 
>  src/util/virhostdev.c | 2 +-
>  src/util/virnetdev.c  | 4 +---
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 

"Some" will say no need to call out Coverity in the short description,
just somewhere in the commit message a "found by coverity" is
sufficient.  And then there's others that are fine with it as is, your
call ;-)

Reviewed-by: John Ferlan <jferlan redhat com>

(series)

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]