[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-php][PATCH] Generate AUTHORS file

On 08/15/2017 10:39 AM, Ján Tomko wrote:
> On Tue, Aug 15, 2017 at 07:43:36AM +0200, Michal Privoznik wrote:
>> On 08/14/2017 05:42 PM, Ján Tomko wrote:
>>> On Sat, Aug 05, 2017 at 02:29:58PM +0200, Michal Privoznik wrote:
>>>> +gen-AUTHORS:
>>>> +    $(AM_V_GEN)if test -d $(srcdir)/.git; then \
>>>> +        out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' |
>>>> sort -u | sed 's/^/\t/'`" && \
>>>> +        perl -p -e "s/#authorslist#// and print '$$out'" \
>>>> +          < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \
>>>> +        mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ; \
>>>> +    fi
>>> What is the point of going through a temporary file and spawning one
>>> extra process on success? We use the pattern a lot in libvirt's Makefile
>>> and it just seems wasteful to me.
>> What extra process do you have in mind?
> mv

Oh yeah. Well I think the idea is to replace AUTHORS iff we successfully
generated it. It doesn't bother me that much to rewrite it. Processes
come and go. But yet again, if you feel like this is a problem be my
guest a propose a patch.

>>> Also, this probably won't work correctly with git work-trees, since
>>> those have .git as a regular file, not a directory. See:
>>> http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=e97dce1b84ab63
>> Well, in that case it's broken in libvirt too. Feel free to fix it and
>> I'll cherry-pick the fix into -php then.
> I volunteer to cherry-pick it to libvirt, just in case you fix it in
> libvirt-php first.

I will not. I don't care that much to try to fix it. Be my guest.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]