[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] network: Use self inflating bitmap for class IDs




On 08/17/2017 03:32 AM, Michal Privoznik wrote:
> Back in the day when I was implementing QoS for networks there
> were no self inflating virBitmaps. Only the static ones.
> Therefore, I had to allocate the whole 8KB of memory in order to
> keep track of used/unused class IDs. This is rather wasteful
> because nobody is ever gonna use that much classes (kernel
> overhead would drastically lower the bandwidth). Anyway, now that
> we have self inflating bitmaps we can start small and allocate
> more if there's need for it.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/conf/virnetworkobj.c    | 18 ++++++++++--------
>  src/network/bridge_driver.c |  5 +++--
>  2 files changed, 13 insertions(+), 10 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]