[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: useserial: drop useless check for serial devices

On Fri, Aug 18, 2017 at 05:19:48PM +0200, Ján Tomko wrote:
> Since its introduction in commit 874e65aa, if someone requests:
> <os><bios useserial="yes"/><os/>
> we report an error if we cannot successfully count the number
> of serial devices via an XPath query.
> Instead of fixing the check (and moving it to the validation phase,
> to prevent existing domains from disappearing), drop it completely.
> For QEMU, the number of serials is checked when building the command
> line.

The check from building the command line should be probably moved to
validation code, but that's for a different patch.

> ---
>  src/conf/domain_conf.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]