[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemu: command: align disk serial check to schema




On 03.08.2017 02:24, John Ferlan wrote:
> 
> 
> On 03/28/2017 04:10 AM, Nikolay Shirokovskiy wrote:
>> Disk serial schema has extra '.+' allowed characters in comparison
>> with check in code. Looks like there is no reason for that as qemu
>> allows any character AFAIK for serial. This discrepancy is originated
>> in 85d15b51 where ability to add serial was added.
>> ---
>>
>> Diff from v1:
>>
>> * fix xml2argv disk serial test to use all valid chars
>>
>> Looks like there is no existing infrastructure to test every invalid character.
>>
>>  src/qemu/qemu_command.c                              | 2 +-
>>  tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args | 2 +-
>>  tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml  | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
> 
> Doing some (personal) mail box cleaning and found this "older" patch...
> Sorry that this has sat unattended (and probably now forgotten or given
> up on) for so long.
> 
> In any case, I adjusted the test to add a second disk rather than
> modifying the first one which was added as a result of commit id
> '5aee81a0c'.
> 
> Reviewed-by: John Ferlan <jferlan redhat com>
> 
> I'll push shortly.
> 
> 

Thanx!

Nikolay


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]