[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] nodedev: add switchdev to NIC capabilities




On 08/21/2017 05:19 AM, Edan David wrote:
> Adding functionality to libvirt that will allow querying the interface
> for the availability of switchdev Offloading NIC capabilities.
> The switchdev mode was introduced in kernel 4.8, the iproute2-devlink
> command to retrieve the swtichdev NIC feature,
> Command example:  devlink dev eswitch show pci/0000:03:00.0
> This feature is needed for Openstack so we can do a scheduling decision
> if the NIC is in Hardware Offload (switchdev) or regular SR-IOV (legacy) mode.
> And select the appropriate hypervisors with the requested capability see [1].
> 
> [1] - https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/enable-sriov-nic-features.html
> ---
>  configure.ac                                      |  13 ++
>  docs/formatnode.html.in                           |   1 +
>  src/util/virnetdev.c                              | 187 +++++++++++++++++++++-
>  src/util/virnetdev.h                              |   1 +
>  tests/nodedevschemadata/net_00_13_02_b9_f9_d3.xml |   1 +
>  tests/nodedevschemadata/net_00_15_58_2f_e9_55.xml |   1 +
>  6 files changed, 203 insertions(+), 1 deletion(-)
> 

Again - make check syntax-check had a failure because properly indent
"#if" to be "# if" (also "# else" and "# endif")

I can fix that easily before pushing though.

Reviewed-by: John Ferlan <jferlan redhat com>

I'll wait a day before pushing - just in case laine comes back from
chasing the eclipse and has a comment to make...

Tks -

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]