[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libxl: Avoid a variable named 'stat'



On Thu, 2017-08-24 at 12:34 +0100, George Dunlap wrote:
> @@ -5401,12 +5401,12 @@ libxlDomainBlockStatsVBD(virDomainObjPtr vm,
>  # define LIBXL_SET_VBDSTAT(FIELD, VAR, MUL)           \
>      if ((virAsprintf(&name, "%s/"FIELD, path) < 0) || \
>          (virFileReadAll(name, 256, &val) < 0) ||      \
> -        (sscanf(val, "%llu", &stat) != 1)) {          \
> +        (sscanf(val, "%llu", &status) != 1)) {          \

You messed up the alignment here...

>          virReportError(VIR_ERR_OPERATION_FAILED,      \
>                         _("cannot read %s"), name);    \
>          goto cleanup;                                 \
>      }                                                 \
> -    VAR += (stat * MUL);                              \
> +    VAR += (status * MUL);                              \

... and here. I've fixed it up before pushing.

Reviewed-by: Andrea Bolognani <abologna redhat com>

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]