[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] spec: Own %{_libdir}/libvirt{, /connection-driver} dirs, mark licenses as %license



On Sun, Aug 27, 2017 at 12:35:07 -0400, Cole Robinson wrote:
> From: Ville Skyttä <ville skytta iki fi>
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1483293
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---

Looks like two separate problems. Also the commit message is rather
sparse.

>  libvirt.spec.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 2b58bf3a9..2d21e60bc 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1794,6 +1794,8 @@ exit 0
>  %dir %attr(0711, root, root) %{_localstatedir}/cache/libvirt/
>  
>  
> +%dir %attr(0755, root, root) %{_libdir}/libvirt/
> +%dir %attr(0755, root, root) %{_libdir}/libvirt/connection-driver/
>  %dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver
>  %attr(0755, root, root) %{_libdir}/libvirt/lock-driver/lockd.so
>  
> @@ -2028,7 +2030,7 @@ exit 0
>  %attr(0755, root, root) %{_libexecdir}/libvirt-guests.sh
>  
>  %files libs -f %{name}.lang
> -%doc COPYING COPYING.LESSER
> +%license COPYING COPYING.LESSERa

According to https://bugzilla.redhat.com/show_bug.cgi?id=1396828 ,
%license will not work on rhel/centos 6.

You should add the hack described in the BZ. Or not change it at all,
since it's not clear from this commit or the bugzilla why it's needed.

Or we can finally drop rhel6 support :P

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]