[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/5] conf: domain: add VIDEO_TYPE_DEFAULT



On Sun, Aug 27, 2017 at 11:04:39AM -0400, Cole Robinson wrote:
> Will be needed for future patches to pull the default video type
> setting out of XML parsing routines.
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/conf/domain_conf.c              | 1 +
>  src/conf/domain_conf.h              | 1 +
>  src/qemu/qemu_command.c             | 3 +++
>  src/qemu/qemu_domain_address.c      | 1 +
>  tests/domaincapsschemadata/full.xml | 1 +
>  5 files changed, 7 insertions(+)

[...]

> diff --git a/tests/domaincapsschemadata/full.xml b/tests/domaincapsschemadata/full.xml
> index 82a92322e..ab6ef9f2e 100644
> --- a/tests/domaincapsschemadata/full.xml
> +++ b/tests/domaincapsschemadata/full.xml
> @@ -62,6 +62,7 @@
>      </graphics>
>      <video supported='yes'>
>        <enum name='modelType'>
> +        <value>default</value>
>          <value>vga</value>
>          <value>cirrus</value>
>          <value>vmvga</value>

This hunk should not be required, but I've checked the code that fills
in domain capabilities and we claim that every video model is supported.
Well that's wrong and should be fixed.

Anyway, the patch itself is good.

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]