[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] qemu: introduce QEMU_CAPS_CHARDEV_RECONNECT



On Mon, Aug 28, 2017 at 03:07:25PM +0200, Ján Tomko wrote:
> On Mon, Aug 28, 2017 at 02:56:49PM +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina redhat com>
> > ---
> > src/qemu/qemu_capabilities.c                            | 2 ++
> > src/qemu/qemu_capabilities.h                            | 1 +
> > tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml | 1 +
> > tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml | 1 +
> > tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml       | 1 +
> > tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml         | 1 +
> > tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml         | 1 +
> > tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml       | 1 +
> > tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml         | 1 +
> > tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml        | 1 +
> > 15 files changed, 16 insertions(+)
> > 
> > diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> > index 8804cc7819..7b59619497 100644
> > --- a/src/qemu/qemu_capabilities.h
> > +++ b/src/qemu/qemu_capabilities.h
> > @@ -423,6 +423,7 @@ typedef enum {
> >     QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE, /* spapr-pci-host-bridge.numa_node= */
> >     QEMU_CAPS_VNC_MULTI_SERVERS, /* -vnc vnc=unix:/path */
> >     QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE, /* virtio-net-*.tx_queue_size */
> > +    QEMU_CAPS_CHARDEV_RECONNECT, /* -chardev *,reconnect */
> 
> We use a dot to separate the attributes in the rest of the comments.

We use the dot for devices, this is not a device.  I can change it to
/* -chardev reconnect */.

Pavel

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]