[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 2/7] lib: Add API to edit domain's managed save state xml configuration



On Tue, Aug 08, 2017 at 13:32:50 +0530, Kothapally Madhu Pavan wrote:
> Similar to domainSaveImageDefineXML this commit adds domainManagedSaveDefineXML
> API which allows to edit domain's managed save state xml configuration.
> 
> Signed-off-by: Kothapally Madhu Pavan <kmp linux vnet ibm com>
> ---
>  include/libvirt/libvirt-domain.h |  4 +++
>  src/driver-hypervisor.h          |  6 +++++
>  src/libvirt-domain.c             | 58 ++++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms          |  1 +
>  src/remote/remote_driver.c       |  1 +
>  src/remote/remote_protocol.x     | 16 ++++++++++-
>  src/remote_protocol-structs      |  8 +++++-
>  7 files changed, 92 insertions(+), 2 deletions(-)

[...]

> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index 67d518c..ddc6bda 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -2556,6 +2556,12 @@ struct remote_domain_managed_save_get_xml_desc_ret {
>      remote_nonnull_string xml;
>  };
>  
> +struct remote_domain_managed_save_define_xml_args {
> +    remote_nonnull_domain dom;
> +    remote_string dxml;

This ...

> +    unsigned int flags;
> +};
> +
>  struct remote_domain_snapshot_create_xml_args {
>      remote_nonnull_domain dom;
>      remote_nonnull_string xml_desc;


> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
> index 27f95ac..8075335 100644
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -1970,6 +1970,11 @@ struct remote_domain_managed_save_get_xml_desc_args {
>  struct remote_domain_managed_save_get_xml_desc_ret {
>          remote_nonnull_string      xml;
>  };
> +struct remote_domain_managed_save_define_xml_args {
> +        remote_nonnull_domain      dom;
> +        remote_nonnull_string      dxml;

... and this does not match, the build has failed.

> +        u_int                      flags;
> +};

More comments perhaps later, I've fixed this in my tree.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]