[libvirt] [PATCH v4 3/7] qemu: Implement qemuDomainManagedSaveGetXMLDesc
Peter Krempa
pkrempa at redhat.com
Mon Aug 28 14:51:54 UTC 2017
On Tue, Aug 08, 2017 at 13:32:51 +0530, Kothapally Madhu Pavan wrote:
> This commit adds qemu driver implementation to get xml description
> for managed save state domain.
>
> Signed-off-by: Kothapally Madhu Pavan <kmp at linux.vnet.ibm.com>
> ---
> src/qemu/qemu_driver.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index b3f65f4..ec73dc1 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -6797,6 +6797,51 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path,
> return ret;
> }
>
> +static char *
> +qemuDomainManagedSaveGetXMLDesc(virDomainPtr dom, unsigned int flags)
> +{
> + virQEMUDriverPtr driver = dom->conn->privateData;
> + virDomainObjPtr vm;
> + char *path = NULL;
> + char *ret = NULL;
> + virDomainDefPtr def = NULL;
> + int fd = -1;
> + virQEMUSaveDataPtr data = NULL;
> +
> + /* We only take subset of virDomainDefFormat flags. */
> + virCheckFlags(VIR_DOMAIN_XML_SECURE, NULL);
> +
> + if (!(vm = qemuDomObjFromDomain(dom)))
> + return ret;
> +
> + path = qemuDomainManagedSavePath(driver, vm);
> +
> + if (!path)
> + goto cleanup;
> +
> + if (!virFileExists(path)) {
> + virReportError(VIR_ERR_OPERATION_INVALID,
> + "%s",_("domain does not have managed save image"));
You did not run syntax-check on this patch:
Invalid character after comma:
src/qemu/qemu_driver.c:6824: "%s",_("domain does not have managed save image"));
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170828/20c95427/attachment-0001.sig>
More information about the libvir-list
mailing list