[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 REBASE 02/16] qemu: introduce qemu domain job status



On Thu, Aug 24, 2017 at 09:56:39 +0300, Nikolay Shirokovskiy wrote:
> This patch simply switches code from using VIR_DOMAIN_JOB_* to
> introduced QEMU_DOMAIN_JOB_STATUS_*. Later this gives us freedom
> to introduce states for postcopy and mirroring phases.
...
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index e9f07c6..d5c70ee 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -12942,14 +12942,13 @@ qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver,
>          info = priv->job.current;
>  
>      if (!info) {
> -        jobInfo->type = VIR_DOMAIN_JOB_NONE;
> +        jobInfo->status = QEMU_DOMAIN_JOB_STATUS_NONE;
>          ret = 0;
>          goto cleanup;
>      }
>      *jobInfo = *info;
>  
> -    if (jobInfo->type == VIR_DOMAIN_JOB_BOUNDED ||

This line should have been removed in the previous patch. Not a big
deal, though.

> -        jobInfo->type == VIR_DOMAIN_JOB_UNBOUNDED) {
> +    if (jobInfo->status == QEMU_DOMAIN_JOB_STATUS_ACTIVE) {
>          if (fetch)
>              ret = qemuMigrationFetchJobStatus(driver, vm, QEMU_ASYNC_JOB_NONE,
>                                                jobInfo);

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]