[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 3/9] Add a test case to verify parsing of VxHS backing storage.




On 08/29/2017 02:39 AM, Ashish Mittal wrote:
> Signed-off-by: Ashish Mittal <Ashish Mittal veritas com>
> ---
>  tests/virstoragetest.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Similarly this probably should be merged with the code that alters
qemu_{command|block}...

> diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
> index d83db78..f8444e1 100644
> --- a/tests/virstoragetest.c
> +++ b/tests/virstoragetest.c
> @@ -1585,6 +1585,16 @@ mymain(void)
>                         "<source protocol='sheepdog' name='Alice'>\n"
>                         "  <host name='10.10.10.10' port='7000'/>\n"
>                         "</source>\n");
> +    TEST_BACKING_PARSE("json:{\"file\":{\"driver\":\"vxhs\","
> +                                       "\"vdisk-id\":\"c6718f6b-0401-441d-a8c3-1f0064d75ee0\","
> +                                       "\"server\": { \"host\":\"example.com\","
> +                                                      "\"port\":\"1234\""
> +                                                   "}"
> +                                      "}"
> +                            "}",
> +                       "<source protocol='vxhs' name='c6718f6b-0401-441d-a8c3-1f0064d75ee0'>\n"
> +                       "  <host name='example.com' port='1234'/>\n"
> +                       "</source>\n");

For consistency, I'll modify port to be 9999 and I'll add the
"type:tcp," string as well to match previous change

John

>  #endif /* WITH_YAJL */
>  
>   cleanup:
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]