[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 REBASE 16/16] qemu: migration: don't expose incomplete job as complete



On Thu, Aug 24, 2017 at 09:56:53 +0300, Nikolay Shirokovskiy wrote:
> In case of real migration (not migrating to file on save, dump etc)
> migration info is not complete at time qemu finishes migration
> in normal (non postcopy) mode. We need to update disks stats,
> downtime info etc. Thus let's not expose this job status as
> completed.
> 
> To archive this let's set status to 'qemu completed' after
> qemu reports migration is finished. It is not visible as complete
> job to clients. Cookie code on confirm phase will finally turn
> job into completed. As we don't need more things to do when
> migrating to file status is set to 'completed' as before
> in this case.
> ---
>  src/qemu/qemu_domain.c    |  1 +
>  src/qemu/qemu_domain.h    |  1 +
>  src/qemu/qemu_driver.c    |  1 +
>  src/qemu/qemu_migration.c | 13 +++++++++----
>  4 files changed, 12 insertions(+), 4 deletions(-)

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]