[libvirt] [PATCH v6 09/13] util: Add virstoragetest to parse/format a tls='yes'
Peter Krempa
pkrempa at redhat.com
Thu Aug 31 11:56:20 UTC 2017
On Wed, Aug 30, 2017 at 18:46:09 -0400, John Ferlan wrote:
> From: Ashish Mittal <Ashish.Mittal at veritas.com>
>
> Add a test case to verify TLS arguments are parsed correctly for a VxHS disk
>
> Test case verifies that XML is generated correctly for a VxHS disk
> having TLS enabled.
>
> Signed-off-by: Ashish Mittal <Ashish.Mittal at veritas.com>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>
> This is essentially the v5 patch7 with a couple of minor adjustments
> (port == 9999 and "type":"tcp" added).
>
> tests/virstoragetest.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
> index ffebd4d..f437de4 100644
> --- a/tests/virstoragetest.c
> +++ b/tests/virstoragetest.c
> @@ -1603,6 +1603,18 @@ mymain(void)
> "<source protocol='vxhs' name='c6718f6b-0401-441d-a8c3-1f0064d75ee0'>\n"
> " <host name='example.com' port='9999'/>\n"
> "</source>\n");
> + TEST_BACKING_PARSE("json:{\"file\":{\"driver\":\"vxhs\","
> + "\"vdisk-id\":\"c6718f6b-0401-441d-a8c3-1f0064d75ee0\","
> + "\"server\": { \"type\":\"tcp\","
> + "\"host\":\"example.com\","
> + "\"port\":\"9999\""
> + "},"
> + "\"tls\":\"yes\""
There is no 'tls' property in the QAPI schema for VXHS [1] drives, so this
test is bogus.
[1]
##
# @BlockdevOptionsVxHS:
#
# Driver specific block device options for VxHS
#
# @vdisk-id: UUID of VxHS volume
# @server: vxhs server IP, port
# @tls-creds: TLS credentials ID
#
# Since: 2.10
##
{ 'struct': 'BlockdevOptionsVxHS',
'data': { 'vdisk-id': 'str',
'server': 'InetSocketAddressBase',
'*tls-creds': 'str' } }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170831/db5dabe7/attachment-0001.sig>
More information about the libvir-list
mailing list