[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v6 12/13] tests: Add test for failure when vxhs_tls=0



On Wed, Aug 30, 2017 at 18:46:12 -0400, John Ferlan wrote:
> From: Ashish Mittal <Ashish Mittal veritas com>
> 
> Add a test case to verify setting vxhs_tls=0 in qemu.conf disables
> TLS for VxHS disks followed by running the same test after enabling
> for the success case.
> 
> Signed-off-by: Ashish Mittal <Ashish Mittal veritas com>
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
> 
>  This is essentially the same v5 patch8 - had to clean up the input
>  XML a bit though.
> 
>  I'm not a fan of this change - I think we should just follow what
>  chardev does and if someone has vxhs_tls = 0 and haveTLS = true,
>  then we just clear the haveTLS and move on.  I think one way or
>  another things will fail in any case.

Me neither. NACK

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]