[libvirt] [PATCH v3 0/4] Move ide validation from qemuBuildControllerDevStr to qemuDomainDeviceDefValidate

Lin Ma lma at suse.com
Fri Dec 1 11:31:28 UTC 2017


Validate IDE controllers in qemuDomainDeviceDefValidate for reminding users earlier.

v2->v3:
* split original patch to multiple patches.
* making the validation is preferred over the PostParse for avoiding guests disappear.
* remove ide from the pseries and the ccw tests.

Lin Ma (4):
  tests: qemuxml2argv: Use scsi controller instead of ide in pseries
  tests: qemuhotplugtest: Drop ide controller in ccw
  qemu_command: Drop IDE validation code in qemuBuildControllerDevStr
  qemu_domain: Error out earlier when configuring IDE controller
    incorrectly

 src/qemu/qemu_command.c                            | 10 +------
 src/qemu/qemu_domain.c                             | 35 +++++++++++++++++++++-
 .../qemuhotplug-base-ccw-live+ccw-virtio.xml       |  4 ---
 ...ive-with-2-ccw-virtio+ccw-virtio-1-explicit.xml |  4 ---
 ...live-with-2-ccw-virtio+ccw-virtio-1-reverse.xml |  4 ---
 ...qemuhotplug-base-ccw-live-with-2-ccw-virtio.xml |  4 ---
 ...-live-with-ccw-virtio+ccw-virtio-2-explicit.xml |  4 ---
 ...-base-ccw-live-with-ccw-virtio+ccw-virtio-2.xml |  4 ---
 .../qemuhotplug-base-ccw-live-with-ccw-virtio.xml  |  4 ---
 .../qemuhotplug-base-ccw-live.xml                  |  4 ---
 .../qemuxml2argv-disk-floppy-pseries.args          |  2 +-
 .../qemuxml2argv-disk-floppy-pseries.xml           |  4 +--
 12 files changed, 38 insertions(+), 45 deletions(-)

-- 
2.9.2




More information about the libvir-list mailing list