[libvirt] [PATCH] qemu: Avoid comparing size_t with -1
Jiri Denemark
jdenemar at redhat.com
Mon Dec 11 13:37:24 UTC 2017
ncpus would be -1 on error and the cleanup for loop would not be skipped
in this case.
Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
---
src/qemu/qemu_capabilities.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 8c65de956e..9673ef857b 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -2965,7 +2965,7 @@ virQEMUCapsFetchCPUDefinitions(qemuMonitorPtr mon)
size_t i;
if ((ncpus = qemuMonitorGetCPUDefinitions(mon, &cpus)) < 0)
- goto error;
+ return NULL;
if (!(models = virDomainCapsCPUModelsNew(ncpus)))
goto error;
--
2.15.1
More information about the libvir-list
mailing list