[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Forbid <memoryBacking><locked> without <memtune><hard_limit>



On Mon, Feb 06, 2017 at 18:29:59 +0100, Andrea Bolognani wrote:
> In order for memory locking to work, the hard limit on memory
> locking (and usage) has to be set appropriately by the user.
> 
> The documentation mentions the requirement already: with this
> patch, it's going to be enforced by runtime checks as well.
> 
> Note that this will make existing guests that don't satisfy
> the requirement disappear; that said, such guests have never
> been able to start in the first place.

Yes, could not start or if they started they would just crash
afterwards. But with your patch they would just disappear and the user
would not even be able to fix the XML. I think the check should be done
prior to starting a domain to avoid this unfortunate behaviour.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]