[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] qemu: Forbid <memoryBacking><locked> without <memtune><hard_limit>



On Tue, Feb 07, 2017 at 02:16:49PM +0100, Andrea Bolognani wrote:
> In order for memory locking to work, the hard limit on memory
> locking (and usage) has to be set appropriately by the user.
> 
> The documentation mentions the requirement already: with this
> patch, it's going to be enforced by runtime checks as well,
> by forbidding a non-compliant guest from being defined as well
> as edited and started.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1316774
> ---
> Changes from [v2]
> 
>   * Address review feedback:
>     - move the check from BuildCommandLine to Validate.
> 
> Changes from [v1]
> 
>   * Address review feeback:
>     - check in BuildCommandLine rather than in PostParse,
>       so that non-compliant guests will merely fail to
>       start rather than disappear completely.
> 
> [v1] https://www.redhat.com/archives/libvir-list/2017-February/msg00180.html
> [v2] https://www.redhat.com/archives/libvir-list/2017-February/msg00214.html
> 
>  src/qemu/qemu_domain.c                           | 10 ++++++++++
>  tests/qemuxml2argvdata/qemuxml2argv-mlock-on.xml |  3 +++
>  2 files changed, 13 insertions(+)

ACK

Pavel

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]