[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/11] qemu_security: Kill code duplication



On Wed, Feb 08, 2017 at 11:37:07 +0100, Michal Privoznik wrote:
> Nearly all of these functions look the same. Except for a
> different virSecurityManager API call. There is no need to copy
> paste the code when we can use macros to generate it.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/qemu/qemu_security.c | 179 ++++++++++++-----------------------------------
>  1 file changed, 44 insertions(+), 135 deletions(-)

NACK, please don't partialy define function with macros.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]