[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 11/11] qemuDomainNamespaceSetupDisk: Simplify disk check



On Wed, Feb 08, 2017 at 11:37:14 +0100, Michal Privoznik wrote:
> Firstly, instead of checking for next->path the
> virStorageSourceIsEmpty() function should be used which also
> takes disk type into account.
> Secondly, not every disk source passed has the correct type set
> (due to our laziness). Therefore, instead of checking for
> virStorageSourceIsBlockLocal() and also S_ISBLK() the former can
> be refined to just virStorageSourceIsLocalStorage().
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/qemu/qemu_domain.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)

ACK

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]