[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 8/9] perf: add alignment_faults software perf event support




On 01/27/2017 06:01 AM, Nitesh Konkar wrote:
> This patch adds support and documentation
> for the alignment_faults perf event.
> 
> Signed-off-by: Nitesh Konkar <nitkon12 linux vnet ibm com>
> ---
>  docs/formatdomain.html.in                   |  7 +++++++
>  docs/news.xml                               |  4 ++--
>  docs/schemas/domaincommon.rng               |  1 +
>  include/libvirt/libvirt-domain.h            | 10 ++++++++++
>  src/libvirt-domain.c                        |  3 +++
>  src/qemu/qemu_driver.c                      |  1 +
>  src/util/virperf.c                          |  6 +++++-
>  src/util/virperf.h                          |  1 +
>  tests/genericxml2xmlindata/generic-perf.xml |  1 +
>  tools/virsh.pod                             |  4 ++++
>  10 files changed, 35 insertions(+), 3 deletions(-)
> 

similar comments here regarding news.xml, formatting the virsh.pod
output, and the length of the description (and where should it be).

John
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 50a6bdb..249cfe4 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -1944,6 +1944,7 @@
>    &lt;event name='cpu_migrations' enabled='no'/&gt;
>    &lt;event name='page_faults_min' enabled='no'/&gt;
>    &lt;event name='page_faults_maj' enabled='no'/&gt;
> +  &lt;event name='alignment_faults' enabled='no'/&gt;
>  &lt;/perf&gt;
>  ...
>  </pre>
> @@ -2059,6 +2060,12 @@
>            platform</td>
>        <td><code>perf.page_faults_maj</code></td>
>      </tr>
> +    <tr>
> +      <td><code>alignment_faults</code></td>
> +      <td>the count of alignment faults by applications running on the
> +          platform</td>
> +      <td><code>perf.alignment_faults</code></td>
> +    </tr>
>    </table>
>  
>      <h3><a name="elementsDevices">Devices</a></h3>
> diff --git a/docs/news.xml b/docs/news.xml
> index fe533f2..b148b38 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -138,8 +138,8 @@
>            executed, branch misses, bus cycles, stalled frontend
>            cpu cycles, stalled backend cpu cycles, ref cpu cycles,
>            cpu clock, task clock, page faults, context switches,
> -          cpu migrations, page faults min and page faults maj by
> -          applications running on the platform.
> +          cpu migrations, page faults min, page faults maj and
> +          alignment faults by applications running on the platform.
>          </description>
>        </change>
>        <change>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 5f986d6..6782bf5 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -440,6 +440,7 @@
>                <value>cpu_migrations</value>
>                <value>page_faults_min</value>
>                <value>page_faults_maj</value>
> +              <value>alignment_faults</value>
>              </choice>
>            </attribute>
>            <attribute name="enabled">
> diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
> index d16200f..7523872 100644
> --- a/include/libvirt/libvirt-domain.h
> +++ b/include/libvirt/libvirt-domain.h
> @@ -2258,6 +2258,16 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats);
>   */
>  # define VIR_PERF_PARAM_PAGE_FAULTS_MAJ  "page_faults_maj"
>  
> +/**
> + * VIR_PERF_PARAM_ALIGNMENT_FAULTS:
> + *
> + * Macro for typed parameter name that represents alignment_faults
> + * perf event which can be used to measure the count of alignment
> + * faults by applications running on the platform. It corresponds
> + * to the "perf.alignment_faults" field in the *Stats APIs.
> + */
> +# define VIR_PERF_PARAM_ALIGNMENT_FAULTS  "alignment_faults"
> +
>  int virDomainGetPerfEvents(virDomainPtr dom,
>                             virTypedParameterPtr *params,
>                             int *nparams,
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index 1d7c181..bad9fea 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -11268,6 +11268,9 @@ virConnectGetDomainCapabilities(virConnectPtr conn,
>   *     "perf.page_faults_maj" - The count of major page faults as unsigned long
>   *                              long. It is produced by the page_faults_maj
>   *                              perf event
> + *     "perf.alignment_faults" - The count of alignment faults as unsigned long
> + *                              long. It is produced by the alignment_faults
> + *                              perf event
>   *
>   * Note that entire stats groups or individual stat fields may be missing from
>   * the output in case they are not supported by the given hypervisor, are not
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index c88bf5a..89394be 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -9556,6 +9556,7 @@ qemuDomainSetPerfEvents(virDomainPtr dom,
>                                 VIR_PERF_PARAM_CPU_MIGRATIONS, VIR_TYPED_PARAM_BOOLEAN,
>                                 VIR_PERF_PARAM_PAGE_FAULTS_MIN, VIR_TYPED_PARAM_BOOLEAN,
>                                 VIR_PERF_PARAM_PAGE_FAULTS_MAJ, VIR_TYPED_PARAM_BOOLEAN,
> +                               VIR_PERF_PARAM_ALIGNMENT_FAULTS, VIR_TYPED_PARAM_BOOLEAN,
>                                 NULL) < 0)
>          return -1;
>  
> diff --git a/src/util/virperf.c b/src/util/virperf.c
> index 37f61e2..c25c57a 100644
> --- a/src/util/virperf.c
> +++ b/src/util/virperf.c
> @@ -46,7 +46,8 @@ VIR_ENUM_IMPL(virPerfEvent, VIR_PERF_EVENT_LAST,
>                "stalled_cycles_backend", "ref_cpu_cycles",
>                "cpu_clock", "task_clock", "page_faults",
>                "context_switches", "cpu_migrations",
> -              "page_faults_min", "page_faults_maj");
> +              "page_faults_min", "page_faults_maj",
> +              "alignment_faults");
>  
>  struct virPerfEvent {
>      int type;
> @@ -136,6 +137,9 @@ static struct virPerfEventAttr attrs[] = {
>      {.type = VIR_PERF_EVENT_PAGE_FAULTS_MAJ,
>       .attrType = PERF_TYPE_SOFTWARE,
>       .attrConfig = PERF_COUNT_SW_PAGE_FAULTS_MAJ},
> +    {.type = VIR_PERF_EVENT_ALIGNMENT_FAULTS,
> +     .attrType = PERF_TYPE_SOFTWARE,
> +     .attrConfig = PERF_COUNT_SW_ALIGNMENT_FAULTS},
>  };
>  typedef struct virPerfEventAttr *virPerfEventAttrPtr;
>  
> diff --git a/src/util/virperf.h b/src/util/virperf.h
> index e99c870..1c51e50 100644
> --- a/src/util/virperf.h
> +++ b/src/util/virperf.h
> @@ -54,6 +54,7 @@ typedef enum {
>      VIR_PERF_EVENT_CPU_MIGRATIONS,   /* Count of cpu migrations */
>      VIR_PERF_EVENT_PAGE_FAULTS_MIN,   /* Count of minor page faults */
>      VIR_PERF_EVENT_PAGE_FAULTS_MAJ,   /* Count of major page faults */
> +    VIR_PERF_EVENT_ALIGNMENT_FAULTS,   /* Count of alignment faults */
>  
>      VIR_PERF_EVENT_LAST
>  } virPerfEventType;
> diff --git a/tests/genericxml2xmlindata/generic-perf.xml b/tests/genericxml2xmlindata/generic-perf.xml
> index a5b6dfb..b48f96c 100644
> --- a/tests/genericxml2xmlindata/generic-perf.xml
> +++ b/tests/genericxml2xmlindata/generic-perf.xml
> @@ -33,6 +33,7 @@
>      <event name='cpu_migrations' enabled='yes'/>
>      <event name='page_faults_min' enabled='yes'/>
>      <event name='page_faults_maj' enabled='yes'/>
> +    <event name='alignment_faults' enabled='yes'/>
>    </perf>
>    <devices>
>    </devices>
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index d6bec4d..1f1b9c9 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -953,6 +953,7 @@ I<--perf> returns the statistics of all enabled perf events:
>  "perf.cpu_migrations" - the count of cpu migrations
>  "perf.page_faults_min" - the count of minor page faults
>  "perf.page_faults_maj" - the count of major page faults
> +"perf.alignment_faults" - the count of alignment faults
>  
>  See the B<perf> command for more details about each event.
>  
> @@ -2336,6 +2337,9 @@ B<Valid perf event names>
>                      the page was not present in the page cache, and therefore
>                      had to be fetched from storage, by applications
>                      running on the platform
> +  alignment_faults - Provides the count of alignment faults, that is when
> +                     the load or store is not aligned properly, by applications
> +                     running on the platform
>  
>  B<Note>: The statistics can be retrieved using the B<domstats> command using
>  the I<--perf> flag.
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]