[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remote generator: handle remoteDomainCreateWithFlags()



On Thu, Feb 09, 2017 at 11:39 PM +0100, John Ferlan <jferlan redhat com> wrote:
> On 01/19/2017 03:17 PM, Marc Hartmayer wrote:
>> This commit removes the handcrafted code for
>> remoteDomainCreateWithFlags() and lets it auto generate.
>> 
>> A little bit of history repeating...
>> Commit 03d813bbcd7b4a183601055006 removed the auto generation of
>> remoteDomainCreateWithFlags() because it was thought that the design
>> flaw in the remote protocol for virDomainCreate is also within the
>> remote protocol for virDomainCreateWithFlags. As the commit message of
>> ddaf15d7a3863d54e242f8ff75 mentions this is not the case therefore we
>> can auto generate the client part.
>> 
>> Even worse there was a typo in remoteDomainCreateWithFlags()
>> 
>> 'remote_domain_create_with_flags_args ret;' but in fact it has to be
>> 'remote_domain_create_with_flags_ret ret;'.
>> 
>> Signed-off-by: Marc Hartmayer <mhartmay linux vnet ibm com>
>> Reviewed-by: Bjoern Walk <bwalk linux vnet ibm com>
>> Reviewed-by: Boris Fiuczynski <fiuczy linux vnet ibm com>
>> ---
>>  src/remote/remote_driver.c   | 29 -----------------------------
>>  src/remote/remote_protocol.x |  2 +-
>>  2 files changed, 1 insertion(+), 30 deletions(-)
>> 
>
> Nice catch -
>
> ACK (and pushed)
>
> John
>

Thanks.


-- 
Beste Grüße / Kind regards
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]