[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver



On Tue, Feb 14, 2017 at 05:14:33PM +0100, Andrea Bolognani wrote:
> On Tue, 2017-02-14 at 16:00 +0000, Daniel P. Berrange wrote:
> > Your platform has libacl available so it is not difficult to fix that
> > by building with libacl support. We print out the configure summary
> > precisely so users can see if there's any libraries they forgot to
> > install which might be useful.
> > 
> > Mandating libacl will prevent use of the QEMU driver on platforms lacking
> > the libacl library.  I see various bug reports indicating portability
> > problems for libacl wrt other platforms, in particular OS-X. So IMHO it
> > is not acceptable to make it a mandatory requirement, when there's no
> > good reason for that aside beyond helping people who forget to install
> > -devel library packages
> 
> FreeBSD and other have <sys/acl.h>, it's just not part of a
> separate package but of libc itself. Not sure about macOS,
> but it being a BSD derivative I expect it wouldn't be too
> different.
> 
> On the other hand, we really only care about having the ACL
> APIs when we are isolating QEMU, which only happens of Linux
> due to the namespaces requirement... So maybe we could have
> it as a strict requirement on Linux only, and as an optional
> dependency on other platforms?

IMHO it'd be better to just disable the namespace code at build
time if we don't have libacl rather than adding mandatory build
deps.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]