[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] spec: Require libacl and its headers



On 02/14/2017 04:33 PM, Andrea Bolognani wrote:
> Now that they're required by configure, we should make sure
> they are available when building the rpm and when installing it.
> ---
>  libvirt.spec.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index e8c272b..ca569e3 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -340,6 +340,8 @@ BuildRequires: polkit-devel >= 0.93
>  # For mount/umount in FS driver
>  BuildRequires: util-linux
>  %if %{with_qemu}
> +# For managing ACLs
> +BuildRequires: libacl-devel
>  # From QEMU RPMs
>  BuildRequires: /usr/bin/qemu-img
>  %else
> @@ -645,6 +647,8 @@ Requires: xz
>      %if 0%{?fedora} >= 24
>  Requires: systemd-container
>      %endif
> +# For managing ACLs
> +Requires: libacl

This shouldn't be needed. If we are building with libacl-devel, we are
also linking with libacl and thus rpm will put it as a requirement.

ACK if you drop this hunk.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]