[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver



On Tue, 2017-02-14 at 16:59 +0000, Daniel P. Berrange wrote:
> > [1] I know I did while trying to figure this bug out ;)
> 
> If we disabled namespace support when libacl is missing at
> build time you would have noticed quite quickly that you
> weren't using namespaces.

Not sure how quickly you'd notice that, it's not like we
would print a big fat warning either at configure time or
when starting a guest, so unless you were looking for it
specifically it would be entirely silent: the guest would
start anyway, it just wouldn't be isolated.

But okay, let's leave making sure all optional dependencies
are in place to users, and most importantly distributions.
As you say, it's consistent with how we deal with other
external libraries.

Michal, can you please take care of cooking up a patch to
disable namespaces when ACL support is not available?

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]