[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v2 10/33] qemu: Rename hostCPU/feature element in capabilities cache



The element will be generalized in the following commit.

Signed-off-by: Jiri Denemark <jdenemar redhat com>
---

Notes:
    Version 2:
    - no change

 src/qemu/qemu_capabilities.c                     |  14 +-
 tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml  |  30 +--
 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 322 +++++++++++------------
 3 files changed, 183 insertions(+), 183 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 688d19504..aab336954 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -3180,7 +3180,7 @@ virQEMUCapsLoadHostCPUModelInfo(virQEMUCapsPtr qemuCaps,
 
     ctxt->node = hostCPUNode;
 
-    if ((n = virXPathNodeSet("./feature", ctxt, &featureNodes)) > 0) {
+    if ((n = virXPathNodeSet("./property", ctxt, &featureNodes)) > 0) {
         if (VIR_ALLOC_N(hostCPU->props, n) < 0)
             goto cleanup;
 
@@ -3191,14 +3191,14 @@ virQEMUCapsLoadHostCPUModelInfo(virQEMUCapsPtr qemuCaps,
             if (!hostCPU->props[i].name) {
                 virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                                _("missing 'name' attribute for a host CPU"
-                                 " model feature in QEMU capabilities cache"));
+                                 " model property in QEMU capabilities cache"));
                 goto cleanup;
             }
 
-            if (!(str = virXMLPropString(featureNodes[i], "supported"))) {
+            if (!(str = virXMLPropString(featureNodes[i], "boolean"))) {
                 virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                               _("missing 'supported' attribute for a host CPU"
-                                 " model feature in QEMU capabilities cache"));
+                               _("missing 'boolean' attribute for a host CPU"
+                                 " model property in QEMU capabilities cache"));
                 goto cleanup;
             }
             if (STREQ(str, "yes")) {
@@ -3207,7 +3207,7 @@ virQEMUCapsLoadHostCPUModelInfo(virQEMUCapsPtr qemuCaps,
                 hostCPU->props[i].supported = false;
             } else {
                 virReportError(VIR_ERR_INTERNAL_ERROR,
-                               _("invalid supported value: '%s'"), str);
+                               _("invalid boolean value: '%s'"), str);
                 goto cleanup;
             }
             VIR_FREE(str);
@@ -3552,7 +3552,7 @@ virQEMUCapsFormatHostCPUModelInfo(virQEMUCapsPtr qemuCaps,
     virBufferAdjustIndent(buf, 2);
 
     for (i = 0; i < model->nprops; i++) {
-        virBufferAsprintf(buf, "<feature name='%s' supported='%s'/>\n",
+        virBufferAsprintf(buf, "<property name='%s' boolean='%s'/>\n",
                           model->props[i].name,
                           model->props[i].supported ? "yes" : "no");
     }
diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
index c4c9bf9d5..1f652bdc2 100644
--- a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
@@ -134,21 +134,21 @@
   <package></package>
   <arch>s390x</arch>
   <hostCPU model='zEC12.2-base'>
-    <feature name='aefsi' supported='yes'/>
-    <feature name='msa5' supported='yes'/>
-    <feature name='msa4' supported='yes'/>
-    <feature name='msa3' supported='yes'/>
-    <feature name='msa2' supported='yes'/>
-    <feature name='msa1' supported='yes'/>
-    <feature name='sthyi' supported='yes'/>
-    <feature name='edat' supported='yes'/>
-    <feature name='ri' supported='yes'/>
-    <feature name='edat2' supported='yes'/>
-    <feature name='ipter' supported='yes'/>
-    <feature name='esop' supported='yes'/>
-    <feature name='cte' supported='yes'/>
-    <feature name='te' supported='yes'/>
-    <feature name='cmm' supported='yes'/>
+    <property name='aefsi' boolean='yes'/>
+    <property name='msa5' boolean='yes'/>
+    <property name='msa4' boolean='yes'/>
+    <property name='msa3' boolean='yes'/>
+    <property name='msa2' boolean='yes'/>
+    <property name='msa1' boolean='yes'/>
+    <property name='sthyi' boolean='yes'/>
+    <property name='edat' boolean='yes'/>
+    <property name='ri' boolean='yes'/>
+    <property name='edat2' boolean='yes'/>
+    <property name='ipter' boolean='yes'/>
+    <property name='esop' boolean='yes'/>
+    <property name='cte' boolean='yes'/>
+    <property name='te' boolean='yes'/>
+    <property name='cmm' boolean='yes'/>
   </hostCPU>
   <cpu type='kvm' name='z10EC-base'/>
   <cpu type='kvm' name='z9EC-base'/>
diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
index ab7906175..c13e8318f 100644
--- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
@@ -206,167 +206,167 @@
   <package> (v2.8.0-877-g38e4b757b4)</package>
   <arch>x86_64</arch>
   <hostCPU model='base'>
-    <feature name='cmov' supported='yes'/>
-    <feature name='ia64' supported='no'/>
-    <feature name='aes' supported='yes'/>
-    <feature name='mmx' supported='yes'/>
-    <feature name='rdpid' supported='no'/>
-    <feature name='arat' supported='yes'/>
-    <feature name='pause-filter' supported='no'/>
-    <feature name='xsavec' supported='yes'/>
-    <feature name='osxsave' supported='no'/>
-    <feature name='kvm-asyncpf' supported='yes'/>
-    <feature name='perfctr-core' supported='no'/>
-    <feature name='mpx' supported='yes'/>
-    <feature name='pbe' supported='no'/>
-    <feature name='avx512cd' supported='no'/>
-    <feature name='decodeassists' supported='no'/>
-    <feature name='sse4.1' supported='yes'/>
-    <feature name='avx512f' supported='no'/>
-    <feature name='msr' supported='yes'/>
-    <feature name='mce' supported='yes'/>
-    <feature name='mca' supported='yes'/>
-    <feature name='xcrypt' supported='no'/>
-    <feature name='xgetbv1' supported='yes'/>
-    <feature name='cid' supported='no'/>
-    <feature name='ds' supported='no'/>
-    <feature name='fxsr' supported='yes'/>
-    <feature name='xsaveopt' supported='yes'/>
-    <feature name='xtpr' supported='no'/>
-    <feature name='avx512vl' supported='no'/>
-    <feature name='avx512-vpopcntdq' supported='no'/>
-    <feature name='phe' supported='no'/>
-    <feature name='extapic' supported='no'/>
-    <feature name='3dnowprefetch' supported='yes'/>
-    <feature name='cr8legacy' supported='no'/>
-    <feature name='xcrypt-en' supported='no'/>
-    <feature name='pn' supported='no'/>
-    <feature name='dca' supported='no'/>
-    <feature name='pku' supported='no'/>
-    <feature name='smx' supported='no'/>
-    <feature name='cmp-legacy' supported='no'/>
-    <feature name='avx512-4fmaps' supported='no'/>
-    <feature name='vmcb-clean' supported='no'/>
-    <feature name='hle' supported='yes'/>
-    <feature name='3dnowext' supported='no'/>
-    <feature name='npt' supported='no'/>
-    <feature name='clwb' supported='no'/>
-    <feature name='lbrv' supported='no'/>
-    <feature name='adx' supported='yes'/>
-    <feature name='ss' supported='yes'/>
-    <feature name='pni' supported='yes'/>
-    <feature name='svm-lock' supported='no'/>
-    <feature name='smep' supported='yes'/>
-    <feature name='smap' supported='yes'/>
-    <feature name='pfthreshold' supported='no'/>
-    <feature name='x2apic' supported='yes'/>
-    <feature name='avx512vbmi' supported='no'/>
-    <feature name='flushbyasid' supported='no'/>
-    <feature name='f16c' supported='yes'/>
-    <feature name='ace2-en' supported='no'/>
-    <feature name='pae' supported='yes'/>
-    <feature name='pat' supported='yes'/>
-    <feature name='sse' supported='yes'/>
-    <feature name='phe-en' supported='no'/>
-    <feature name='kvm-nopiodelay' supported='yes'/>
-    <feature name='tm' supported='no'/>
-    <feature name='kvmclock-stable-bit' supported='yes'/>
-    <feature name='hypervisor' supported='yes'/>
-    <feature name='pcommit' supported='no'/>
-    <feature name='syscall' supported='yes'/>
-    <feature name='avx512dq' supported='no'/>
-    <feature name='svm' supported='no'/>
-    <feature name='invtsc' supported='no'/>
-    <feature name='sse2' supported='yes'/>
-    <feature name='est' supported='no'/>
-    <feature name='avx512ifma' supported='no'/>
-    <feature name='tm2' supported='no'/>
-    <feature name='kvm-pv-eoi' supported='yes'/>
-    <feature name='cx8' supported='yes'/>
-    <feature name='kvm-mmu' supported='no'/>
-    <feature name='sse4.2' supported='yes'/>
-    <feature name='pge' supported='yes'/>
-    <feature name='pdcm' supported='no'/>
-    <feature name='movbe' supported='yes'/>
-    <feature name='nrip-save' supported='no'/>
-    <feature name='ssse3' supported='yes'/>
-    <feature name='sse4a' supported='no'/>
-    <feature name='invpcid' supported='yes'/>
-    <feature name='pdpe1gb' supported='yes'/>
-    <feature name='tsc-deadline' supported='yes'/>
-    <feature name='fma' supported='yes'/>
-    <feature name='cx16' supported='yes'/>
-    <feature name='de' supported='yes'/>
-    <feature name='xsave' supported='yes'/>
-    <feature name='clflush' supported='yes'/>
-    <feature name='skinit' supported='no'/>
-    <feature name='tsc' supported='yes'/>
-    <feature name='tce' supported='no'/>
-    <feature name='fpu' supported='yes'/>
-    <feature name='ds-cpl' supported='no'/>
-    <feature name='ibs' supported='no'/>
-    <feature name='fma4' supported='no'/>
-    <feature name='la57' supported='no'/>
-    <feature name='osvw' supported='no'/>
-    <feature name='apic' supported='yes'/>
-    <feature name='pmm' supported='no'/>
-    <feature name='tsc-adjust' supported='yes'/>
-    <feature name='kvm-steal-time' supported='yes'/>
-    <feature name='kvmclock' supported='yes'/>
-    <feature name='lwp' supported='no'/>
-    <feature name='xop' supported='no'/>
-    <feature name='avx' supported='yes'/>
-    <feature name='ospke' supported='no'/>
-    <feature name='acpi' supported='no'/>
-    <feature name='avx512bw' supported='no'/>
-    <feature name='ace2' supported='no'/>
-    <feature name='fsgsbase' supported='yes'/>
-    <feature name='ht' supported='no'/>
-    <feature name='nx' supported='yes'/>
-    <feature name='pclmulqdq' supported='yes'/>
-    <feature name='mmxext' supported='no'/>
-    <feature name='popcnt' supported='yes'/>
-    <feature name='xsaves' supported='yes'/>
-    <feature name='lm' supported='yes'/>
-    <feature name='umip' supported='no'/>
-    <feature name='pse' supported='yes'/>
-    <feature name='avx2' supported='yes'/>
-    <feature name='sep' supported='yes'/>
-    <feature name='nodeid-msr' supported='no'/>
-    <feature name='misalignsse' supported='no'/>
-    <feature name='bmi1' supported='yes'/>
-    <feature name='bmi2' supported='yes'/>
-    <feature name='kvm-pv-unhalt' supported='yes'/>
-    <feature name='tsc-scale' supported='no'/>
-    <feature name='topoext' supported='no'/>
-    <feature name='clflushopt' supported='yes'/>
-    <feature name='monitor' supported='no'/>
-    <feature name='avx512er' supported='no'/>
-    <feature name='pmm-en' supported='no'/>
-    <feature name='pcid' supported='yes'/>
-    <feature name='3dnow' supported='no'/>
-    <feature name='erms' supported='yes'/>
-    <feature name='lahf-lm' supported='yes'/>
-    <feature name='fxsr-opt' supported='no'/>
-    <feature name='xstore' supported='no'/>
-    <feature name='rtm' supported='yes'/>
-    <feature name='lmce' supported='yes'/>
-    <feature name='perfctr-nb' supported='no'/>
-    <feature name='rdrand' supported='yes'/>
-    <feature name='rdseed' supported='yes'/>
-    <feature name='avx512-4vnniw' supported='no'/>
-    <feature name='vme' supported='yes'/>
-    <feature name='vmx' supported='yes'/>
-    <feature name='dtes64' supported='no'/>
-    <feature name='mtrr' supported='yes'/>
-    <feature name='rdtscp' supported='yes'/>
-    <feature name='pse36' supported='yes'/>
-    <feature name='tbm' supported='no'/>
-    <feature name='wdt' supported='no'/>
-    <feature name='sha-ni' supported='no'/>
-    <feature name='abm' supported='yes'/>
-    <feature name='avx512pf' supported='no'/>
-    <feature name='xstore-en' supported='no'/>
+    <property name='cmov' boolean='yes'/>
+    <property name='ia64' boolean='no'/>
+    <property name='aes' boolean='yes'/>
+    <property name='mmx' boolean='yes'/>
+    <property name='rdpid' boolean='no'/>
+    <property name='arat' boolean='yes'/>
+    <property name='pause-filter' boolean='no'/>
+    <property name='xsavec' boolean='yes'/>
+    <property name='osxsave' boolean='no'/>
+    <property name='kvm-asyncpf' boolean='yes'/>
+    <property name='perfctr-core' boolean='no'/>
+    <property name='mpx' boolean='yes'/>
+    <property name='pbe' boolean='no'/>
+    <property name='avx512cd' boolean='no'/>
+    <property name='decodeassists' boolean='no'/>
+    <property name='sse4.1' boolean='yes'/>
+    <property name='avx512f' boolean='no'/>
+    <property name='msr' boolean='yes'/>
+    <property name='mce' boolean='yes'/>
+    <property name='mca' boolean='yes'/>
+    <property name='xcrypt' boolean='no'/>
+    <property name='xgetbv1' boolean='yes'/>
+    <property name='cid' boolean='no'/>
+    <property name='ds' boolean='no'/>
+    <property name='fxsr' boolean='yes'/>
+    <property name='xsaveopt' boolean='yes'/>
+    <property name='xtpr' boolean='no'/>
+    <property name='avx512vl' boolean='no'/>
+    <property name='avx512-vpopcntdq' boolean='no'/>
+    <property name='phe' boolean='no'/>
+    <property name='extapic' boolean='no'/>
+    <property name='3dnowprefetch' boolean='yes'/>
+    <property name='cr8legacy' boolean='no'/>
+    <property name='xcrypt-en' boolean='no'/>
+    <property name='pn' boolean='no'/>
+    <property name='dca' boolean='no'/>
+    <property name='pku' boolean='no'/>
+    <property name='smx' boolean='no'/>
+    <property name='cmp-legacy' boolean='no'/>
+    <property name='avx512-4fmaps' boolean='no'/>
+    <property name='vmcb-clean' boolean='no'/>
+    <property name='hle' boolean='yes'/>
+    <property name='3dnowext' boolean='no'/>
+    <property name='npt' boolean='no'/>
+    <property name='clwb' boolean='no'/>
+    <property name='lbrv' boolean='no'/>
+    <property name='adx' boolean='yes'/>
+    <property name='ss' boolean='yes'/>
+    <property name='pni' boolean='yes'/>
+    <property name='svm-lock' boolean='no'/>
+    <property name='smep' boolean='yes'/>
+    <property name='smap' boolean='yes'/>
+    <property name='pfthreshold' boolean='no'/>
+    <property name='x2apic' boolean='yes'/>
+    <property name='avx512vbmi' boolean='no'/>
+    <property name='flushbyasid' boolean='no'/>
+    <property name='f16c' boolean='yes'/>
+    <property name='ace2-en' boolean='no'/>
+    <property name='pae' boolean='yes'/>
+    <property name='pat' boolean='yes'/>
+    <property name='sse' boolean='yes'/>
+    <property name='phe-en' boolean='no'/>
+    <property name='kvm-nopiodelay' boolean='yes'/>
+    <property name='tm' boolean='no'/>
+    <property name='kvmclock-stable-bit' boolean='yes'/>
+    <property name='hypervisor' boolean='yes'/>
+    <property name='pcommit' boolean='no'/>
+    <property name='syscall' boolean='yes'/>
+    <property name='avx512dq' boolean='no'/>
+    <property name='svm' boolean='no'/>
+    <property name='invtsc' boolean='no'/>
+    <property name='sse2' boolean='yes'/>
+    <property name='est' boolean='no'/>
+    <property name='avx512ifma' boolean='no'/>
+    <property name='tm2' boolean='no'/>
+    <property name='kvm-pv-eoi' boolean='yes'/>
+    <property name='cx8' boolean='yes'/>
+    <property name='kvm-mmu' boolean='no'/>
+    <property name='sse4.2' boolean='yes'/>
+    <property name='pge' boolean='yes'/>
+    <property name='pdcm' boolean='no'/>
+    <property name='movbe' boolean='yes'/>
+    <property name='nrip-save' boolean='no'/>
+    <property name='ssse3' boolean='yes'/>
+    <property name='sse4a' boolean='no'/>
+    <property name='invpcid' boolean='yes'/>
+    <property name='pdpe1gb' boolean='yes'/>
+    <property name='tsc-deadline' boolean='yes'/>
+    <property name='fma' boolean='yes'/>
+    <property name='cx16' boolean='yes'/>
+    <property name='de' boolean='yes'/>
+    <property name='xsave' boolean='yes'/>
+    <property name='clflush' boolean='yes'/>
+    <property name='skinit' boolean='no'/>
+    <property name='tsc' boolean='yes'/>
+    <property name='tce' boolean='no'/>
+    <property name='fpu' boolean='yes'/>
+    <property name='ds-cpl' boolean='no'/>
+    <property name='ibs' boolean='no'/>
+    <property name='fma4' boolean='no'/>
+    <property name='la57' boolean='no'/>
+    <property name='osvw' boolean='no'/>
+    <property name='apic' boolean='yes'/>
+    <property name='pmm' boolean='no'/>
+    <property name='tsc-adjust' boolean='yes'/>
+    <property name='kvm-steal-time' boolean='yes'/>
+    <property name='kvmclock' boolean='yes'/>
+    <property name='lwp' boolean='no'/>
+    <property name='xop' boolean='no'/>
+    <property name='avx' boolean='yes'/>
+    <property name='ospke' boolean='no'/>
+    <property name='acpi' boolean='no'/>
+    <property name='avx512bw' boolean='no'/>
+    <property name='ace2' boolean='no'/>
+    <property name='fsgsbase' boolean='yes'/>
+    <property name='ht' boolean='no'/>
+    <property name='nx' boolean='yes'/>
+    <property name='pclmulqdq' boolean='yes'/>
+    <property name='mmxext' boolean='no'/>
+    <property name='popcnt' boolean='yes'/>
+    <property name='xsaves' boolean='yes'/>
+    <property name='lm' boolean='yes'/>
+    <property name='umip' boolean='no'/>
+    <property name='pse' boolean='yes'/>
+    <property name='avx2' boolean='yes'/>
+    <property name='sep' boolean='yes'/>
+    <property name='nodeid-msr' boolean='no'/>
+    <property name='misalignsse' boolean='no'/>
+    <property name='bmi1' boolean='yes'/>
+    <property name='bmi2' boolean='yes'/>
+    <property name='kvm-pv-unhalt' boolean='yes'/>
+    <property name='tsc-scale' boolean='no'/>
+    <property name='topoext' boolean='no'/>
+    <property name='clflushopt' boolean='yes'/>
+    <property name='monitor' boolean='no'/>
+    <property name='avx512er' boolean='no'/>
+    <property name='pmm-en' boolean='no'/>
+    <property name='pcid' boolean='yes'/>
+    <property name='3dnow' boolean='no'/>
+    <property name='erms' boolean='yes'/>
+    <property name='lahf-lm' boolean='yes'/>
+    <property name='fxsr-opt' boolean='no'/>
+    <property name='xstore' boolean='no'/>
+    <property name='rtm' boolean='yes'/>
+    <property name='lmce' boolean='yes'/>
+    <property name='perfctr-nb' boolean='no'/>
+    <property name='rdrand' boolean='yes'/>
+    <property name='rdseed' boolean='yes'/>
+    <property name='avx512-4vnniw' boolean='no'/>
+    <property name='vme' boolean='yes'/>
+    <property name='vmx' boolean='yes'/>
+    <property name='dtes64' boolean='no'/>
+    <property name='mtrr' boolean='yes'/>
+    <property name='rdtscp' boolean='yes'/>
+    <property name='pse36' boolean='yes'/>
+    <property name='tbm' boolean='no'/>
+    <property name='wdt' boolean='no'/>
+    <property name='sha-ni' boolean='no'/>
+    <property name='abm' boolean='yes'/>
+    <property name='avx512pf' boolean='no'/>
+    <property name='xstore-en' boolean='no'/>
   </hostCPU>
   <cpu type='kvm' name='max' usable='yes'/>
   <cpu type='kvm' name='host' usable='yes'/>
-- 
2.11.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]