[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 05/12] qemu: drop excessive zero-out in qemuMigrationFetchJobStatus



On Wed, Dec 28, 2016 at 17:39:14 +0300, Nikolay Shirokovskiy wrote:
> qemuMonitorGetMigrationStats will do it for us anyway.
> ---
>  src/qemu/qemu_migration.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 05ff2a0..6ddc4bd 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -2595,7 +2595,6 @@ qemuMigrationFetchJobStatus(virQEMUDriverPtr driver,
>      if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
>          return -1;
>  
> -    memset(&jobInfo->stats, 0, sizeof(jobInfo->stats));
>      rv = qemuMonitorGetMigrationStats(priv->mon, &jobInfo->stats);
>  
>      if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0)

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]