[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] cputest: Fix name of the file removed by cpu-parse.sh



On Fri, Feb 17, 2017 at 11:06:46 +0100, Erik Skultety wrote:
> On Thu, Feb 16, 2017 at 02:46:04PM +0100, Jiri Denemark wrote:
> > We want to remove the file created by
> > 
> >     json <<<"$data" >$fname.json
> > 
> > in case it was empty.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar redhat com>
> > ---
> >  tests/cputestdata/cpu-parse.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/cputestdata/cpu-parse.sh b/tests/cputestdata/cpu-parse.sh
> > index 1b5ab4a5a..c3b5ef106 100755
> > --- a/tests/cputestdata/cpu-parse.sh
> > +++ b/tests/cputestdata/cpu-parse.sh
> > @@ -53,5 +53,5 @@ json <<<"$data" >$fname.json
> >  if [[ -s $fname.json ]]; then
> >      echo $fname.json
> >  else
> > -    rm $fname.new.json
> > +    rm $fname.json
> 
> Hmm, interesting mistake.

It's just a leftover from a previous private version of the script. This
filename was actually used at some point.

> ACK

Thanks, pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]