[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libvirt-override: fix flags mutually exclusize



On Fri, Feb 17, 2017 at 10:20:34AM -0600, Eric Blake wrote:
> On 02/17/2017 08:26 AM, Daniel P. Berrange wrote:
> 
> > It isn't that simple - this isn't a mere matter of checking data. The use
> > of the getters during the setter method is a fundamental requirement. At
> > the C layer we have many distinct data types - eg int, unsigned int,
> > long long, unsigned long long, which all map to the same python data
> > type.
> > 
> 
> Is it worth improving the C code to do relaxed parsing (if the C type is
> int, but the caller passes a long long with a value that fits in an int,
> to accept the caller instead of rejecting it as a type mismatch)?

I don't see much benefit in that - any app or language binding that
relied on such a feature would find itself needlessly broken when
run against older libvirt.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]