[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter_gentech_driver: Fix indentation and typo



On Fri, Feb 17, 2017 at 07:39:41PM +0530, Nitesh Konkar wrote:
Signed-off-by: Nitesh Konkar <nitkon12 linux vnet ibm com>
---
src/nwfilter/nwfilter_gentech_driver.c | 4 ++--
src/nwfilter/nwfilter_gentech_driver.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)


You are sending quite some amount of patches that do no functional
change.  That takes review time and adds a lot of unnecesary
communication.  While we appreciate patches, sending more and more small
patches that are not really needed is tiresome for most parties
involved.

If we stumple upon such typo or indentation, we either push it right
away as trivial (only if you have push access, though) or just keep it
in a separate branch and after a while, send it as a big patch which is
just one mail.  That way it doesn't take that much of a time and
resources.

Most of the time, though, the time spent on the typo/indentation fixing
could be spent on something better, more useful, and also rewarding.  So
most of the things get fixed just because someone has some patches
already in that area of code.

Have a nice day,
Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]