[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/13] qemu: Create #define for TLS configuration setup.




On 02/20/2017 04:17 AM, Peter Krempa wrote:
> On Mon, Feb 20, 2017 at 08:54:26 +0100, Peter Krempa wrote:
>> On Fri, Feb 17, 2017 at 14:39:18 -0500, John Ferlan wrote:
>>> Create GET_CONFIG_TLS_CERT to set up the TLS for 'chardev' TLS setting.
>>> Soon to be reused.
>>>
>>> Signed-off-by: John Ferlan <jferlan redhat com>
>>> ---
>>>  src/qemu/qemu_conf.c | 41 +++++++++++++++++++++++++----------------
>>>  1 file changed, 25 insertions(+), 16 deletions(-)
>>
>> Is it possible to do this as a function and not a macro?
> 
> So, this is going to be reused in the same function. That is okay with
> me as long as you #undef the macro right away so that it's clear that
> it's not used anywhere else.
> 

Right - I forgot the #undef. Conceptually it would be used for
"chardev", "migrate", and "nbd" (although I'm wondering if anyone would
ever go through the process to set up 3 different TLS envs).

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]