[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Disallow inclusion of files from src/conf into src/utils



On Mon, Feb 20, 2017 at 14:58:49 +0100, Peter Krempa wrote:
> The utils code should stay separated from other code (except for very
> well justified cases). Unfortunately commit 272769beccd7479c75e700a6cb
> made it trivial to break the separation (and not get slapped by the
> syntax-check rule) by adding -I src/conf to the CFLAGS for utils.
> 
> Remove this shortcut and except the two offenders from the syntax check
> so that the codebase can be kept separated.
> ---
>  cfg.mk                       | 3 +++
>  src/Makefile.am              | 3 +--
>  src/util/virclosecallbacks.h | 2 +-
>  src/util/virhostdev.h        | 2 +-
>  4 files changed, 6 insertions(+), 4 deletions(-)

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]