[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter_gentech_driver: Fix indentation and typo



On 02/20/2017 05:27 AM, Martin Kletzander wrote:
On Fri, Feb 17, 2017 at 07:39:41PM +0530, Nitesh Konkar wrote:
Signed-off-by: Nitesh Konkar <nitkon12 linux vnet ibm com>
---
src/nwfilter/nwfilter_gentech_driver.c | 4 ++--
src/nwfilter/nwfilter_gentech_driver.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)


You are sending quite some amount of patches that do no functional
change.  That takes review time and adds a lot of unnecesary
communication.

My issue with patches that only change formatting is that any touched lines will have the history of their last functional change obscured by the formatting change, making it more difficult to do forensic analysis of the reasoning behind the code's existence (which is often very useful when trying to fix a regression without causing a different regression). These changes can also e the cause of merge errors when backporting future bug fixes onto older maintenance branches.

Sometimes the advantage of making the change outweighs the potential extra burden, but not always. Clean consistent code is nice to have, but it doesn't need to be perfect.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]