[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/13] conf: always display iothread ids in the XML



On Fri, Feb 17, 2017 at 15:49:09 +0100, Pavel Hrdina wrote:
> There was at first only iothreads element in the XML.  Because
> iothreads are used by theirs ids we should always print them in
> the XML even if they are auto-generated.
> 
> Signed-off-by: Pavel Hrdina <phrdina redhat com>
> ---
>  src/conf/domain_conf.c                             | 32 +++++-----------------
>  src/conf/domain_conf.h                             |  1 -
>  src/qemu/qemu_driver.c                             |  2 --
>  src/qemu/qemu_process.c                            |  5 ++--
>  .../qemuxml2xmlout-cputune-iothreads.xml           |  4 +++
>  ...l2xmlout-cputune-iothreadsched-zeropriority.xml |  6 ++++
>  .../qemuxml2xmlout-cputune-iothreadsched.xml       |  6 ++++
>  .../qemuxml2xmlout-cputune-numatune.xml            |  4 +++
>  .../qemuxml2xmlout-iothreads-disk-virtio-ccw.xml   |  4 +++
>  .../qemuxml2xmlout-iothreads-disk.xml              |  4 +++
>  .../qemuxml2xmlout-iothreads-ids-partial.xml       |  2 ++
>  .../qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml   |  4 +++
>  .../qemuxml2xmlout-iothreads-virtio-scsi-pci.xml   |  4 +++
>  .../qemuxml2xmlout-iothreads.xml                   |  4 +++
>  .../qemuxml2xmlout-vcpu-placement-static.xml       |  4 +++
>  15 files changed, 55 insertions(+), 31 deletions(-)

I'm not quite sure whether we should do this globally. I think that
adding a function that will show us whether we should format the full
list or not would be a better idea. That way you could add the new
parameters to it and still omit the formatting of the full list in cases
where nothing was specified.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]