[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/11] storage: backend: Refactor registration of the backend drivers



On Fri, Feb 10, 2017 at 08:19:33 -0500, John Ferlan wrote:
> 
> 
> On 02/08/2017 11:27 AM, Peter Krempa wrote:
> > Add APIs that allow to dynamically register driver backends so that the
> > list of available drivers does not need to be known during compile time.
> > 
> > This will allow us to modularize the storage driver on runtime.
> > ---
> >  src/storage/storage_backend.c          | 111 ++++++++++++++++++++++-----------
> >  src/storage/storage_backend.h          |   5 ++
> >  src/storage/storage_backend_disk.c     |   7 +++
> >  src/storage/storage_backend_disk.h     |   4 +-
> >  src/storage/storage_backend_fs.c       |  27 ++++++++
> >  src/storage/storage_backend_fs.h       |  11 +---
> >  src/storage/storage_backend_gluster.c  |  13 +++-
> >  src/storage/storage_backend_gluster.h  |   5 +-
> >  src/storage/storage_backend_iscsi.c    |   7 +++
> >  src/storage/storage_backend_iscsi.h    |   4 +-
> >  src/storage/storage_backend_logical.c  |   7 +++
> >  src/storage/storage_backend_logical.h  |   4 +-
> >  src/storage/storage_backend_mpath.c    |   8 +++
> >  src/storage/storage_backend_mpath.h    |   4 +-
> >  src/storage/storage_backend_rbd.c      |   7 +++
> >  src/storage/storage_backend_rbd.h      |   4 +-
> >  src/storage/storage_backend_scsi.c     |   7 +++
> >  src/storage/storage_backend_scsi.h     |   4 +-
> >  src/storage/storage_backend_sheepdog.c |   7 +++
> >  src/storage/storage_backend_sheepdog.h |   4 +-
> >  src/storage/storage_backend_vstorage.c |   7 +++
> >  src/storage/storage_backend_vstorage.h |   4 +-
> >  src/storage/storage_backend_zfs.c      |   7 +++
> >  src/storage/storage_backend_zfs.h      |   4 +-
> >  src/storage/storage_driver.c           |   2 +
> >  tests/virstoragetest.c                 |   4 ++
> >  26 files changed, 200 insertions(+), 78 deletions(-)
> > 
> 
> [1] The one difference I note with these patches is that
> virStorageFileBackendDir *is* included for the virStorageFileBackends;
> whereas, prior to this patch it was not included in fileBackends.
> 
> It's not a problem per se, but just wanted to make sure it was
> intentional...

The initial omission was unintentional. Thankfully directory storage
sources are very uncommon since the drivers to expose them in the guest
are rather old. I'll keep it here as is.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]