[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver



On Wed, Feb 22, 2017 at 10:34:12 +0100, Peter Krempa wrote:
> On Mon, Feb 13, 2017 at 23:53:43 +0100, Tomáš Golembiovský wrote:
> > The 'raw' block driver in Qemu is not directly interesting from
> > libvirt's perspective, but it can be layered above some other block
> > drivers and this may be interesting for the user.
> > 
> > The patch adds support for the 'raw' block driver. The driver is treated
> > simply as a pass-through and child driver in JSON is queried to get the
> > necessary information.
> > 
> > Signed-off-by: Tomáš Golembiovský <tgolembi redhat com>
> > ---
> >  src/util/virstoragefile.c | 16 ++++++++++++++++
> >  tests/virstoragetest.c    |  6 ++++++
> >  2 files changed, 22 insertions(+)
> > 
> > diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
> > index 3698eeeda..0447016bf 100644
> > --- a/src/util/virstoragefile.c
> > +++ b/src/util/virstoragefile.c
> > @@ -2648,6 +2648,11 @@ virStorageSourceParseBackingColon(virStorageSourcePtr src,
> >  
> >  
> >  static int
> > +virStorageSourceParseBackingJSONInternal(virStorageSourcePtr src,
> > +                                         virJSONValuePtr json);
> 
> We try to avoid forward declaration as much as possible. It's better to
> move the code.

And this one can't be avoided ... :)

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]