[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 06/33] qemu: Skip virQEMUCapsCPUFilterFeatures on non-x86 CPUs



On Tue, Feb 21, 2017 at 09:24:33 -0500, John Ferlan wrote:
> 
> 
> On 02/15/2017 11:44 AM, Jiri Denemark wrote:
> > All features the function is currently supposed to filter out are
> > specific to x86_64. We should avoid removing them on other
> > architectures. It seems to be quite unlikely other achitectures would
> > use the same names, but one can never be sure.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar redhat com>
> > ---
> > 
> > Notes:
> >     Version 2:
> >     - no change
> > 
> >  src/qemu/qemu_capabilities.c | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> 
> This works since the only filtered features happen to be X86 features,
> right? If so, then that assumption could eventually change and someone
> would have to know to dig into virQEMUCapsCPUFilterFeatures to change...
> 
> Just thinking while typing...
> 
> ACK to what's here

Thanks. I pushed it since it didn't have any dependencies on the other
patches in this series.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]