[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Use explicit boolean comparison in OOM check



On 02/22/2017 12:52 PM, Daniel P. Berrange wrote:
GCC 7 gets upset by

    if (!tmp && (size * count))

warning

   util/viralloc.c: In function 'virReallocN':
   util/viralloc.c:246:23: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context]
      if (!tmp && (size * count)) {
                  ~~~~~~^~~~~~~~

Keep it happy by adding != 0 to the right hand expression
so it realizes we really are wanting to treat the result
of the arithmetic expression as a boolean

ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]