[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH go v2] Add support for perf events





On Fri, Feb 24, 2017 at 4:06 PM, Daniel P. Berrange <berrange redhat com> wrote:
On Fri, Feb 24, 2017 at 11:02:33AM +0100, Peter Krempa wrote:
> On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote:
> > Signed-off-by: Nitesh Konkar <nitkon12 linux vnet ibm com>
> > ---
> >  connect.go      | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  domain.go       | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  domain_compat.h | 36 ++++++++++++++++++++++++++++++++++++
> >  3 files changed, 144 insertions(+)
>
> The files are improperly indented. The go files use tabs for indentation
> while your code uses spaces. I've already pointed this out in v1.

More specifically the go files use 'gofmt' for formatting. The best way
to achieve this is to setup your editor to automatically run gofmt when
saving files. If you are using emacs this is achieved by installing and
using this lisp file
Thanks Daniel. However I am using vim and I think
gofmt -w domain.go and gofmt -w connect.go would help me
achieve the same.

  https://github.com/dominikh/go-mode.el

Regards,
Daniel
--
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]